Skip to main content
Module

x/croner/CONTRIBUTING.md

Trigger functions and/or evaluate cron expressions in JavaScript. No dependencies. Most features. All environments.
Go to Latest
File

Welcome to Croner contributing guide

New contributor guide

To get an overview of the project, read the README. Here are some resources to help you get started with open source contributions:

Getting started

Issues

Create a new issue

If you spot a problem with Croner, search if an issue already exists. If a related issue doesn’t exist, you can open a new issue using a relevant issue form.

Solve an issue

Scan through our existing issues to find one that interests you. You can narrow down the search using labels as filters. If you find an issue to work on, make a note in the comments so er van assign it to you. Then you are welcome to open a PR with a fix.

Make Changes

Setting up the environment

Se recommend using VS Code with eslint extensions, which will automatically check your code against THE defined rules as you write it.

  1. Fork the repository.
  • Using GitHub Desktop:
  • Getting started with GitHub Desktop will guide you through setting up Desktop.
  • Once Desktop is set up, you can use it to fork the repo!
  • Using the command line:
  • Fork the repo so that you can make your changes without affecting the original project until you’re ready to merge them.
  1. Install or update to Node.js v16.
  2. Create a working branch feature/my-cool-feature or bugfix/issue-14 and start with your changes!

Testing your changes

Make sure you add test cases for your changes. While developing, use npm run test to run run quick tests against /src/*.

Commit your update

Please run npm run build before committing, to update the dist-files, and to make sure every test and check passes. When using this command, both source code, and all generated code will be tested, so it can take a while.

If you make changes to any function Interface, or to JSDoc in general, you should also run npm run build:docs to update the generated documentation.

See package.json scripts section for all available scripts.

Then, commit the changes once you are happy with them.

Pull Request

When you’re finished with the changes, create a pull request, also known as a PR.

  • Don’t forget to link PR to issue if you are solving one.

  • Enable the checkbox to allow maintainer edits so the branch can be updated for a merge. Once you submit your PR, a team member will review your proposal. We may ask questions or request for additional information.

  • We may ask for changes to be made before a PR can be merged, either using suggested changes or pull request comments. You can apply suggested changes directly through the UI. You can make any other changes in your fork, then commit them to your branch.

  • As you update your PR and apply changes, mark each conversation as resolved.

  • If you run into any merge issues, checkout this git tutorial to help you resolve merge conflicts and other issues.

Success

This guide is based on GitHub Docs CONTRIBUTING.md